dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle
wrapper jar from source
URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400459182
##########
File path: build.gradle
##########
@@ -54,6 +55,7 @@ ext {
// if the build file is incorrectly written and evaluates something
// eagerly).
+apply from: file('gradle/wrapper.gradle')
Review comment:
Gradle version to download should be in gradle-wrapper.properties. The
wrapper JAR itself typically works across versions (in my experience) but I
hear your point. There is also the checksum-validation issue...
Maybe we could ask legal for clarification whether this particular JAR can
be distributed as part of source releases? This restriction makes things
annoyingly complex to maintain for close to zero benefit...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
