[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071676#comment-17071676
]
Jason Gerlowski commented on SOLR-7871:
---------------------------------------
The scripts/include files are a huge testing gap, source of duplication, and
blocker for improvements. Many are reluctant to do the windows-testing
required to make script changes, so they either skip the testing or only update
the nix script - both of which have bitten us recently. So I think this is
still a good idea.
As to why it stalled out, there's probably a few reasons. I didn't have the
karma to commit it myself back in '17, and though Jan was giving me reviews I
think maybe it was a pretty large-impact change to merge from a someone that
wasn't a committer yet, or that hadn't yet proven he would stick around.
Additionally it's a big change to an area where there aren't really any tests,
which also made it difficult to pursue.
In any case, I agree with Jan - this is going to be impacted by the SIP-6
effort if someone takes that on. If SIP-6 work starts getting momentum in the
short term, maybe this should wait until after (or be rolled into that?). If
SIP-6 doesn't get momentum or stalls out for whatever reason, I'd be all for
this ticket resumed (and would be happy to review with a mind toward
committing).
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
