gerlowskija commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag URL: https://github.com/apache/lucene-solr/pull/1391#discussion_r400837339
########## File path: solr/bin/solr ########## @@ -2089,6 +2089,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the option for users to disable it when. Review comment: [-1] The way I read this, the Admin UI will be disabled whenever SOLR_ADMIN_UI_ENABLED is empty, unset, etc. And I don't see that value set anywhere, except in commented-out lines in solr.in.sh/solr.in.cmd. So by default the Admin UI is disabled, which doesn't seem like your intention? Or am I missing something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
