mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r401228325
########## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ########## @@ -93,4 +93,11 @@ */ void collect(int doc) throws IOException; + /* + * optionally returns an iterator over competitive documents Review comment: Thanks @jpountz > It's probably worth making explicit as null iterators are elsewhere interpreted as matching no documents What is the way to make this explicit? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org