[
https://issues.apache.org/jira/browse/LUCENE-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072602#comment-17072602
]
Atri Sharma commented on LUCENE-9299:
-------------------------------------
Can you open a PR instead? Easier to review.
I was split with the same decision when working on 8811. IMO, we should be
throwing an error when the max clause count is *breached*, which is what the
current check accomplishes. Hence this was intentionally done.
Keep in mind that this can be potentially a breaking change -- some queries
that worked before might stop working all of a sudden post an upgrade.
> ClausesCheckVisitor fails to throw TooManyClauses exception when the clauses
> in a query exceeds the limit by 1
> --------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-9299
> URL: https://issues.apache.org/jira/browse/LUCENE-9299
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: master (9.0)
> Reporter: Stamatis Zampetakis
> Priority: Trivial
> Attachments: LUCENE-9299.patch
>
>
> The visitor that was introduced in LUCENE-8811 (obtained by
> IndexSearcher#getNumClausesCheckVisitor) that checks that the number of
> clauses in query does not exceed a certain limit (defined by
> org.apache.lucene.search.IndexSearcher#setMaxClauseCount) misses the case
> where the clauses/terms in the query exceed the limit by one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
