Simon Willnauer created LUCENE-9304:
---------------------------------------

             Summary: Clean up DWPTPool 
                 Key: LUCENE-9304
                 URL: https://issues.apache.org/jira/browse/LUCENE-9304
             Project: Lucene - Core
          Issue Type: Improvement
    Affects Versions: master (9.0), 8.6
            Reporter: Simon Willnauer


DWPTPool currently uses an indirection called ThreadState to hold DWPT 
instances. This class holds several information that belongs in other places, 
inherits from ReentrantLock and has a mutable nature. Instead we could pool the 
DWPT directly and remove other indirections  inside DWPTFlushControl if we move 
some of the ThreadState properties to DWPT directly. The threadpool also has a 
problem that is grows it's ThreadStates to the number of concurrently indexing 
threads but never shrinks it if they are reduced. With pooling DWPT directly 
this limitation could be removed. 
In summary, this component has seen quite some refactoring and requires some 
cleanups and docs changes in order to stay the test of time.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to