dsmiley opened a new pull request #1399: SOLR-14376: optimize SolrIndexSearcher.getDocSet matches everything URL: https://github.com/apache/lucene-solr/pull/1399 https://issues.apache.org/jira/browse/SOLR-14376 * getProcessedFilter now returns null filter if it's all docs more reliably * getProcessedFilter now documented clearly as an internal method * getDocSet detects all-docs and exits early with getLiveDocs The PR depends on #1381 (SOLR-14364 LTR to not call getProcessedFilter) because the current code there incorrectly assumed that a null ProcessedFilter.filter meant match nothing when it's the opposite. Since a null filter is set more reliably now, it resulted in some tests over there failing. Really people should avoid this low level method if they can. The PR has improved javadocs and some changes in getProcessedFilter I added to improve readability (to me, any way). I also touched getDocSetBits & makeDocSetBits trivially to check where an instanceof check happens because I thought it was clearer.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
