bruno-roustant commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405518985
########## File path: lucene/core/src/java/org/apache/lucene/util/fst/FSTEnum.java ########## @@ -178,7 +179,7 @@ protected void doSeekCeil() throws IOException { } else { if (targetIndex < 0) { targetIndex = -1; - } else if (arc.bitTable().isBitSet(targetIndex)) { Review comment: I agree. I'd like to review FSTEnum soon. First to refactor and share common code like this, second there is still room for some perf improvement I think for seek floor/ceil. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org