jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r403471265
########## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ########## @@ -91,6 +91,7 @@ private String field; private Type type; // defaults to determining type dynamically boolean reverse = false; // defaults to natural order + private boolean skipNonCompetitiveDocs = false; // if true, sortField will use a comparator that can skip non-competitive docs Review comment: I'd rather not have this on SortField for now. This is an old API that never required fields to be indexed. I'd rather have new SortField implementations for now, and later look at how we can enable this in SortField. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
