[
https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087858#comment-17087858
]
Jason Gerlowski commented on SOLR-14391:
----------------------------------------
I attached some a performance test driver to the early revisions of SOLR-13892,
for others to verify the improvement. One copy of it can be found as
{{TestJoinQueryPerformance}} in this PR:
https://github.com/apache/lucene-solr/pull/1159/files
That said, without having looked at this change here, I can't say whether that
driver is relevant/helpful at all. The driver runs at the http API level, so
you'd have to put in the plumbing to expose both alternatives if it's not there
currently. The data generation that the drive does was also pretty specific to
the "join" use case I was looking at in S-13892, so you'd likely need to change
that pretty significantly to match things here.
> Remove getDocSet's manual doc collection logic; remove ScoreFilter
> ------------------------------------------------------------------
>
> Key: SOLR-14391
> URL: https://issues.apache.org/jira/browse/SOLR-14391
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 8.6
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{SolrIndexSearcher.getDocSet(List<Query>)}} calls getProcessedFilter and
> then basically loops over doc IDs, passing them through the filter, and
> passes them to the Collector. This logic is redundant with what Lucene
> searcher.search(query,collector) will ultimately do in BulkScorer, and so I
> propose we remove all that code and delegate to Lucene.
> Also, the top of this method looks to see if any query implements the
> "ScoreFilter" marker interface (only implemented by CollapsingPostFilter) and
> if so delegates to {{getDocSetScore}} method instead. That method has an
> implementation close to what I propose getDocSet be changed to; so it can be
> removed along with this ScoreFilter interface
> searcher.search(query,collector).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
