[ https://issues.apache.org/jira/browse/SOLR-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090545#comment-17090545 ]
ASF subversion and git services commented on SOLR-12690: -------------------------------------------------------- Commit eb8d3d3a0f2e039a64e74b296eb64da2ae530800 in lucene-solr's branch refs/heads/branch_8x from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=eb8d3d3 ] SOLR-12690: Regularize LoggerFactory declarations. Fixing an incorrect change > Regularize LoggerFactory declarations > ------------------------------------- > > Key: SOLR-12690 > URL: https://issues.apache.org/jira/browse/SOLR-12690 > Project: Solr > Issue Type: Improvement > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Minor > Fix For: 7.5, 8.0 > > Attachments: SOLR-12690.patch, SOLR-12690.patch > > > LoggerFactory declarations have several different forms, they should all be: > private static final Logger log = > LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); > * lowercase log > * private static > * non hard-coded class lookup. > I'm going to regularize all of these, I think there are about 80 currently, > we've been nibbling away at this but I'll try to do it in one go. > [~cpoerschke] I think there's another Jira about this that I can't find just > now, ring any bells? > Once that's done, is there a good way to make violations of this fail > precommit? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org