[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092514#comment-17092514
]
David Smiley commented on LUCENE-8638:
--------------------------------------
I fixed up the branch a lot; mostly Solr but I'll leave that discussion for
SOLR-13138
The removal of the deprecated method SloppyMath.haversinKilometers (in lieu of
haversineMeters) has the unfortunate side effect of changing the definition of
the {{haversine()}} function in the expressions module which is mapped to that
method. In the patch I fixed the reference and the tests so it compiles and
tests pass. _However_, that's a super sneaky back-compat break. Instead we
should probably retain the current semantics either by just keeping the method
or by moving this method into the expressions module as an internal detail.
> Remove deprecated code in master
> --------------------------------
>
> Key: LUCENE-8638
> URL: https://issues.apache.org/jira/browse/LUCENE-8638
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Fix For: master (9.0)
>
>
> There are a number of deprecations in master that should be removed. This
> issue is to keep track of deprecations as a whole, some individual
> deprecations may require their own issues.
>
> Work on this issue should be pushed to the `master-deprecations` branch on
> gitbox
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
