samuelgmartinez opened a new pull request #1480: URL: https://github.com/apache/lucene-solr/pull/1480
# Description `HttpSolrCall` and `HttpSolrClient` were using `Content-Encoding` header incorrectly, as they were setting the charset as the encoding for the request. This bug surfaces only when a Solr node is forwarding a request to another node and tries to forward the original headers. # Solution Adjusted the behaviour to set the charset encoding as part of the `Content-Type` (as is specified by the HTTP standard) and `Content-Encoding` is now properly forwarded when available. # Tests Run the Solr test suites successfully but only from IntelliJ as from the terminal was failing everywhere (from lucene tests to some other random failures, even with badapples set to false). Regardin new/modified unit tests, none. Since the `HttpSolrCall` has no tests and this takes a really complicated setup to test it, I just wanted to verify that the introduced changes won't break existing suites. Of course I'm open to add them but I'd appreciate some direction on how to build such a test. # Checklist Please review the following and check all that apply: - [ x ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ x ] I have created a Jira issue and added the issue ID to my pull request title. - [ x ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ x ] I have developed this patch against the `master` branch. - [ x ] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
