[ https://issues.apache.org/jira/browse/LUCENE-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Woodward resolved LUCENE-9348. ----------------------------------- Fix Version/s: 8.6 Resolution: Fixed > Rework grouping tests to make it simpler to add new GroupSelector > implementations > --------------------------------------------------------------------------------- > > Key: LUCENE-9348 > URL: https://issues.apache.org/jira/browse/LUCENE-9348 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Major > Fix For: 8.6 > > Time Spent: 20m > Remaining Estimate: 0h > > The grouping module tests currently all try and test both grouping by term > and grouping by ValueSource. They are quite difficult to follow, however, > and it is not at all easy to add tests for a new grouping type. We should > refactor things into an abstract base class that can then be extended by > tests for each specific grouping type. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org