[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104731#comment-17104731 ]
Tomas Eduardo Fernandez Lobbe commented on SOLR-13289: ------------------------------------------------------ bq. Should we really add numFoundExact="true" on responses I thought about this too. But my plan is to make the default value for {{minFoundHits}} a configuration in solrconfig.xml (and maybe even lower that in master to something like 10k or something). So the parameter wouldn't be explicitly passed every time. I guess still, one could choose to not use the feature (by providing a negative value or Integer.MAX_VALUE), but it does become a much more common thing. Implementation-wise, it would be messy to move a flag around to figure out if we need to include or not the value in the response bq. Wouldn't we want the controlling parameter to use "numFound" likewise instead of "hits"? Yes, makes sense. bq. I propose minNumFoundToBeExact Maybe we can have something shorter? {{minExactNumFound}}? I also like {{minExactCount}}, which I feels sounds a bit better, but more disconnected from {{numFound}} bq. I spent some time today reviewing what you pushed more closely, Thanks, I'll take a look today > Support for BlockMax WAND > ------------------------- > > Key: SOLR-13289 > URL: https://issues.apache.org/jira/browse/SOLR-13289 > Project: Solr > Issue Type: New Feature > Reporter: Ishan Chattopadhyaya > Assignee: Tomas Eduardo Fernandez Lobbe > Priority: Major > Attachments: SOLR-13289.patch, SOLR-13289.patch > > Time Spent: 3h 40m > Remaining Estimate: 0h > > LUCENE-8135 introduced BlockMax WAND as a major speed improvement. Need to > expose this via Solr. When enabled, the numFound returned will not be exact. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org