[
https://issues.apache.org/jira/browse/LUCENE-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105293#comment-17105293
]
Alan Woodward commented on LUCENE-9369:
---------------------------------------
I opened a PR here: https://github.com/apache/lucene-solr/pull/1513
There are some open questions on this:
1) Testing Solr's version of the ValueSourceGroupSelector - currently
BaseGroupSelectorTestCase is in the grouping module's test class module, which
is not visible to Solr tests. We have two options here, firstly to export the
grouping tests as a test jar and add this as a dependency to Solr; or
alternatively, to move BaseGroupSelectorTestCase to the lucene-test-framework
module, which will require adding a dependency on the grouping module. I think
either are fine?
2) This is removing functionality, in that you can no longer group by the
string value of a ValueSource. We don't actually have any VS implementations
that produce arbitrary strings - we have constants (no use for grouping!), or
we have docvalues (equivalent to the TermGroupSelector) - but that doesn't
necessarily mean that somebody hasn't implemented one elsewhere. If this looks
like it will cause a problem, we could investigate adding a BinaryValuesSource,
by analogy with Long/DoubleValuesSource, and adding a group selector that uses
this. I can see this would be useful for normalizing values after indexing,
for example.
> Deprecate grouping by ValueSource
> ---------------------------------
>
> Key: LUCENE-9369
> URL: https://issues.apache.org/jira/browse/LUCENE-9369
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
>
> LUCENE-7889 allows grouping by DoubleValuesSource and LongValuesSource. We
> can now deprecate the ValueSourceGroupingSelector, and in 9x remove the
> grouping module's dependency on the queries module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
