[ https://issues.apache.org/jira/browse/SOLR-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113272#comment-17113272 ]
Lucene/Solr QA commented on SOLR-14504: --------------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 46m 24s{color} | {color:green} core in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 50m 31s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-14504 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13003634/SOLR-14504.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 9c066f60f18 | | ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/753/testReport/ | | modules | C: solr/core U: solr/core | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/753/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > ZkController LiveNodesListener has NullPointerException in startup race > ----------------------------------------------------------------------- > > Key: SOLR-14504 > URL: https://issues.apache.org/jira/browse/SOLR-14504 > Project: Solr > Issue Type: Bug > Affects Versions: 7.7, 7.7.1, 7.7.2, 8.0, 8.1, 8.2, 7.7.3, 8.1.1, 8.3, > 8.4, 8.3.1, 8.5, 8.4.1, 8.5.1 > Reporter: Colvin Cowie > Priority: Minor > Attachments: SOLR-14504.patch > > > If a NODELOST event happens before the cloudManager is initialized then a > NullPointerException will occur on this line > [https://github.com/apache/lucene-solr/blob/c18666ad05afc02979c150aacd4810cff02e43f3/solr/core/src/java/org/apache/solr/cloud/ZkController.java#L1020] > {code:java} > byte[] json = Utils.toJSON(Collections.singletonMap("timestamp", > cloudManager.getTimeSource().getEpochTimeNs())); {code} > Rather than accessing cloudManager directly, getSolrCloudManager() should be > called. > > This happens very rarely, but if it happens it will stop Solr starting, > result in "CoreContainer is either not initialized or shutting down". Snippet > from 8.3.1 > {noformat} > 2020-05-19 03:44:40.241 INFO (main) [ ] o.a.s.c.c.ConnectionManager > Waiting for client to connect to ZooKeeper > 2020-05-19 03:44:40.245 INFO (zkConnectionManagerCallback-11-thread-1) [ ] > o.a.s.c.c.ConnectionManager zkClient has connected > 2020-05-19 03:44:40.245 INFO (main) [ ] o.a.s.c.c.ConnectionManager Client > is connected to ZooKeeper > 2020-05-19 03:44:40.359 INFO (main) [ ] o.a.s.c.c.ConnectionManager > Waiting for client to connect to ZooKeeper > 2020-05-19 03:44:40.361 INFO (zkConnectionManagerCallback-13-thread-1) [ ] > o.a.s.c.c.ConnectionManager zkClient has connected > 2020-05-19 03:44:40.361 INFO (main) [ ] o.a.s.c.c.ConnectionManager Client > is connected to ZooKeeper > 2020-05-19 03:44:40.417 INFO (main) [ ] o.a.s.c.c.ZkStateReader Updated > live nodes from ZooKeeper... (0) -> (1) > 2020-05-19 > 03:44:56.606 INFO (zkCallback-12-thread-2) [ ] > o.a.s.c.c.ZkStateReader Updated live nodes from ZooKeeper... (1) -> > (0) > 2020-05-19 03:44:56.614 ERROR (main) [ ] > o.a.s.s.SolrDispatchFilter Could not start Solr. Check solr/home > property and the logs > 2020-05-19 03:44:56.639 ERROR (main) [ ] o.a.s.c.SolrCore > null:java.lang.NullPointerException > at > org.apache.solr.cloud.ZkController.lambda$registerLiveNodesListener$10(ZkController.java:1020) > at > org.apache.solr.common.cloud.ZkStateReader.registerLiveNodesListener(ZkStateReader.java:880) > at > org.apache.solr.cloud.ZkController.registerLiveNodesListener(ZkController.java:1035) > at org.apache.solr.cloud.ZkController.init(ZkController.java:917) > at org.apache.solr.cloud.ZkController.<init>(ZkController.java:473) > at org.apache.solr.core.ZkContainer.initZooKeeper(ZkContainer.java:115) > at > org.apache.solr.core.CoreContainer.load(CoreContainer.java:631){noformat} > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org