[ 
https://issues.apache.org/jira/browse/SOLR-14280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114348#comment-17114348
 ] 

Jason Gerlowski commented on SOLR-14280:
----------------------------------------

bq. I only fixed one line but maybe it would be better to replace all the 
similar log lines.
By similar log lines, are you referring to similar places in SolrConfig?  Or 
are you just referring generically to places where we log warnings/errors 
without including the exception message?

For what it's worth, I'd be happy to commit this as-is.  There's definitely 
other places where we can improve our logging, but I don't want to let the 
perfect get in the way of the good.  If you've got other places you'd like to 
address as part of this jira, feel free.  But if you don't have immediate plans 
for that, I'll merge your one-liner patch as is so people can start benefiting 
from it.

> SolrConfig logging not helpful
> ------------------------------
>
>                 Key: SOLR-14280
>                 URL: https://issues.apache.org/jira/browse/SOLR-14280
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Andras Salamon
>            Priority: Minor
>         Attachments: SOLR-14280-01.patch
>
>
> SolrConfig prints out a warning message if it's not able to add files to the 
> classpath, but this message is not too helpful:
> {noformat}
> o.a.s.c.SolrConfig Couldn't add files from 
> /opt/cloudera/parcels/CDH-7.1.1-1.cdh7.1.1.p0.1850855/lib/solr/dist filtered 
> by solr-langid-\d.*\.jar to classpath: 
> /opt/cloudera/parcels/CDH-7.1.1-1.cdh7.1.1.p0.1850855/lib/solr/
> dist {noformat}
> The reason should be at the end of the log message but it's just repeats the 
> problematic file name.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to