[ 
https://issues.apache.org/jira/browse/SOLR-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121301#comment-17121301
 ] 

Michael Gibney commented on SOLR-14467:
---------------------------------------

Yes, this all sounds good to me. I wasn't sure what was going on with the null 
vs absent stats, so I'm glad there's a logical explanation (and that that's 
fixed now!).

It took me a while to dig into the 2 beast logs, but I think the issue has to 
do with {{FacetFieldProcessorByArray}} and refinement requests where 
{{allBuckets:true}}. The attached patch ([^SOLR-14467_allBuckets_refine.patch]) 
I think fixes the problem by intercepting (and ignoring) normal calls to 
{{countAcc.collect(...)}} in such situations, and by setting {{otherAccs=accs}} 
to allow {{setNextReader(...)}} to be called on accs during what is essentially 
"single-pass" collection (with {{allBuckets}} bucket being ultimately the only 
collect target).

> inconsistent server errors combining relatedness() with allBuckets:true
> -----------------------------------------------------------------------
>
>                 Key: SOLR-14467
>                 URL: https://issues.apache.org/jira/browse/SOLR-14467
>             Project: Solr
>          Issue Type: Bug
>          Components: Facet Module
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-14467.patch, SOLR-14467.patch, SOLR-14467.patch, 
> SOLR-14467_allBuckets_refine.patch, SOLR-14467_test.patch, 
> SOLR-14467_test.patch, beast.log.txt, beast2.log.txt
>
>
> While working on randomized testing for SOLR-13132 i discovered a variety of 
> different ways that JSON Faceting's "allBuckets" option can fail when 
> combined with the "relatedness()" function.
> I haven't found a trivial way to manual reproduce this, but i have been able 
> to trigger the failures with a trivial patch to {{TestCloudJSONFacetSKG}} 
> which i will attach.
> Based on the nature of the failures it looks like it may have something to do 
> with multiple segments of different sizes, and or resizing the SlotAccs ?
> The relatedness() function doesn't have much (any?) existing tests in place 
> that leverage "allBuckets" so this is probably a bug that has always existed 
> -- it's possible it may be excessively cumbersome to fix and we might 
> nee/wnat to just document that incompatibility and add some code to try and 
> detect if the user combines these options and if so fail with a 400 error?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to