[ 
https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-14520:
--------------------------------------
    Attachment: SOLR-14520.patch
        Status: Open  (was: Open)


bq. Perhaps the key to reproducing might be to figure out how/when 
partialBuckets for subs are initially populated...

The tests i added in the last patch were already triggering the partialBuckets 
refinement -- the important bits i was overlooking was that in order to trigger 
the ArrayIndexOutOfBoundsException we needed *BOTH* of the following to be true 
when refining a facet of a partial bucket...

# the facet uses default sort by count (so that we collect against the 
countAcc, collecting against the acc from some other stat leads to the other 
NPE alreayd accounted for in the test)
# we trigger refinement of a bucket that has a slot number > 0

I had considered #1, but didn't really grasp that the existing test data was so 
small all noe of the requests were tickling #2.

The attached patch just adds a 'cat5' example facet that would trigger the 
AIOOBE -- but doesn't because the fix works.

bq. I still need to review & think about michael's solution a bit more before 
commiting ...

I'm feeling more confident, but still beasting for a bit in conjunction with 
the other test improvements in SOLR-14467

Unless i run into any problems, or there are any objections, I'll probably move 
forward & commit tomorow.



> json.facets: allBucket:true can cause server errors when combined with 
> refine:true
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-14520
>                 URL: https://issues.apache.org/jira/browse/SOLR-14520
>             Project: Solr
>          Issue Type: Bug
>          Components: Facet Module
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-14520.patch, SOLR-14520.patch, SOLR-14520.patch
>
>
> Another bug that was discovered while testing SOLR-14467...
> In some situations, using {{allBuckets:true}} in conjunction with 
> {{refine:true}} can cause server errors during the "refinement" requests to 
> the individual shards -- either NullPointerExceptions from some (nested) 
> SlotAccs when SpecialSlotAcc tries to collect them, or 
> ArrayIndexOutOfBoundsException from CountSlotArrAcc.incrementCount because 
> it's asked to collect to "large" slot# values even though it's been 
> initialized with a size of '1'
> NOTE: these problems may be specific to FacetFieldProcessorByArrayDV - i have 
> not yet seen similar failures from FacetFieldProcessorByArrayUIF (those are 
> the only 2 used when doing refinement) but that may just be a fluke of 
> testing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to