dweiss commented on a change in pull request #1550:
URL: https://github.com/apache/lucene-solr/pull/1550#discussion_r434805283
##########
File path: lucene/benchmark/build.gradle
##########
@@ -15,13 +15,13 @@
* limitations under the License.
*/
-
-apply plugin: 'java-library'
+apply plugin: 'java'
+// NOT a 'java-library'. Maybe 'application' but seems too limiting.
Review comment:
From my (seasoned) gradle viewpoint this comment really doesn't make
much sense: it's not an "application" in gradle sense - we launch multiple
classes, have infrastructure in the build file, not a main class etc. But fine
with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
