vthacker commented on a change in pull request #1559:
URL: https://github.com/apache/lucene-solr/pull/1559#discussion_r437848904
##########
File path:
solr/core/src/test/org/apache/solr/search/TestReRankQParserPlugin.java
##########
@@ -645,5 +650,95 @@ public void testReRankQueriesWithDefType() throws
Exception {
);
}
}
+
+ @Test
+ public void testMinExactCount() throws Exception {
+
+ assertU(delQ("*:*"));
+ assertU(commit());
+
+ int numDocs = 200;
+
+ for (int i = 0 ; i < numDocs ; i ++) {
+ assertU(adoc(
+ "id", String.valueOf(i),
+ "id_p_i", String.valueOf(i),
+ "field_t", IntStream.range(0, numDocs).mapToObj(val ->
Integer.toString(val)).collect(Collectors.joining(" "))));
+ }
+ assertU(commit());
+
+ ModifiableSolrParams params = new ModifiableSolrParams();
+ params.add("q", "field_t:0");
+ params.add("start", "0");
+ params.add("rows", "10");
+ params.add("fl", "id");
+ assertQ(req(params),
+ "*[count(//doc)=10]",
+ "//result[@numFound='" + numDocs + "']",
+ "//result[@numFoundExact='true']",
+ "//result/doc[1]/str[@name='id'][.='0']",
+ "//result/doc[2]/str[@name='id'][.='1']",
+ "//result/doc[3]/str[@name='id'][.='2']",
+ "//result/doc[4]/str[@name='id'][.='3']",
+ "//result/doc[5]/str[@name='id'][.='4']",
+ "//result/doc[6]/str[@name='id'][.='5']",
+ "//result/doc[7]/str[@name='id'][.='6']",
+ "//result/doc[8]/str[@name='id'][.='7']",
+ "//result/doc[9]/str[@name='id'][.='8']",
+ "//result/doc[10]/str[@name='id'][.='9']"
+ );
+
+ params.add("rq", "{!"+ReRankQParserPlugin.NAME+"
"+ReRankQParserPlugin.RERANK_QUERY+"=$rrq
"+ReRankQParserPlugin.RERANK_DOCS+"=20}");
+ params.add("rrq", "id:10");
+ assertQ(req(params),
+ "*[count(//doc)=10]",
+ "//result[@numFound='" + numDocs + "']",
+ "//result[@numFoundExact='true']",
+ "//result/doc[1]/str[@name='id'][.='10']",
+ "//result/doc[2]/str[@name='id'][.='0']",
+ "//result/doc[3]/str[@name='id'][.='1']",
+ "//result/doc[4]/str[@name='id'][.='2']",
+ "//result/doc[5]/str[@name='id'][.='3']",
+ "//result/doc[6]/str[@name='id'][.='4']",
+ "//result/doc[7]/str[@name='id'][.='5']",
+ "//result/doc[8]/str[@name='id'][.='6']",
+ "//result/doc[9]/str[@name='id'][.='7']",
+ "//result/doc[10]/str[@name='id'][.='8']"
+ );
+
+ params.add(CommonParams.MIN_EXACT_COUNT, "2");
Review comment:
So we are allowed to set `MIN_EXACT_COUNT` <
`ReRankQParserPlugin.RERANK_DOCS` ?
In this case should we tell the re-rank collector to
`ReRankQParserPlugin.RERANK_DOCS` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
