noblepaul commented on a change in pull request #1542:
URL: https://github.com/apache/lucene-solr/pull/1542#discussion_r438043059
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java
##########
@@ -644,15 +643,13 @@ public Session cloneToNewSession(SolrCloudManager
cloudManager) {
List<Clause> expandedClauses = new ArrayList<>(this.expandedClauses);
List<Row> matrix = new ArrayList<>(nodes.size());
+ Map<String, Row> copyNodes = new HashMap<>();
+ for (Row oldRow: this.matrix) {
Review comment:
>even those that might not be needed
I believe it's a reasonable tradeoff because most of the times nodes do not
go away. Yes, we make an extra copy in those rare occasions, but it should be
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
