[ 
https://issues.apache.org/jira/browse/SOLR-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136333#comment-17136333
 ] 

ASF subversion and git services commented on SOLR-14384:
--------------------------------------------------------

Commit 35bdf9b413512fa4b2e360df14991f27462ecb6f in lucene-solr's branch 
refs/heads/branch_8x from Nazerke Seidan
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=35bdf9b ]

SOLR-14384: SolrRequestInfo now stacks internally.
* "set" now MUST pair with a "clear"
* fixes SolrIndexSearcher.warm which should have re-instated previous SRI
* cleans up some SRI set/clear users

Closes #1527

(cherry picked from commit 2da71c2a405483e2cf5270dfc20cbd760cd66486)


> Stack SolrRequestInfo
> ---------------------
>
>                 Key: SOLR-14384
>                 URL: https://issues.apache.org/jira/browse/SOLR-14384
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Sometimes SolrRequestInfo need to be suspended/overridden with a new one that 
> is used temporarily. Examples are in the {{[subquery]}} transformer, and in 
> warm of caches, and in QuerySenderListener (another type of warming), maybe 
> others.  This can be annoying to do correctly, and in at least one place it 
> isn't done correctly.  SolrRequestInfoSuspender shows some complexity.  In 
> this issue, [~dsmiley] proposes using a stack internally to SolrRequestInfo 
> that is push'ed and pop'ed.  It's not the only way to solve this but it's one 
> way.
>  See linked issues for the context and discussion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to