dsmiley commented on pull request #1514: URL: https://github.com/apache/lucene-solr/pull/1514#issuecomment-645120762
Last minute request: also please change solrUrlWhitelist to avoid this "whitelist" word (think current events) to, I propose "allowSolrUrls". There's a discussion going on now internally that probably should be public about this sort of thing. There's another patch to add a new similar thing for file system paths deliberately named "allowPaths", so that influenced my suggested new name here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
