noblepaul commented on a change in pull request #1432:
URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r443953444
##########
File path: solr/core/src/java/org/apache/solr/pkg/PackageListeners.java
##########
@@ -69,7 +69,7 @@ synchronized void packagesUpdated(List<PackageLoader.Package>
pkgs) {
invokeListeners(pkgInfo);
}
} finally {
- MDCLoggingContext.clear();
+ if(core != null) MDCLoggingContext.clear();
Review comment:
> PackageListeners.core will never be null
Now it's not.
The schema plugins will no more be associated with a core. They will have it
as `null`. I don't need to deal with it in this. So, I'll remove the null check
now. `PackageListeners` is not used in ContainerPlugins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
