[ 
https://issues.apache.org/jira/browse/SOLR-14376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143071#comment-17143071
 ] 

Christine Poerschke commented on SOLR-14376:
--------------------------------------------

quick question: just spotted a
{code:java}
// TODO optimize getDocSet to make this check unnecessary SOLR-14376
{code}
comment at 
[https://github.com/apache/lucene-solr/blob/5bfbdc5325aa331549e9700734042c9b582fc3fc/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java#L176]and
 not sure if that was inadvertently left in (SOLR-14376 is resolved here) or if 
it should be kept but updated somehow perhaps? thanks!

> Optimize SolrIndexSearcher.getDocSet and getProcessedFilter for empty fq
> ------------------------------------------------------------------------
>
>                 Key: SOLR-14376
>                 URL: https://issues.apache.org/jira/browse/SOLR-14376
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>             Fix For: 8.6
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If either SolrIndexSearcher.getDocSet or getProcessedFilter are called with 
> an null/empty query list, we should be able to short-circuit this with a 
> getLiveDocSet response.  Today getDocSet builds up a new DocSet, bit by bit 
> :-/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to