jimczi commented on a change in pull request #1610:
URL: https://github.com/apache/lucene-solr/pull/1610#discussion_r445460474



##########
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##########
@@ -394,6 +399,21 @@ public String toString() {
     return buffer.toString();
   }
 
+
+  /**
+   * For numeric sort fields, setting this field, indicates that
+   * the same numeric data has been indexed with two fields: doc values and 
points and
+   * that these fields have the same name.
+   * This allows to use sort optimization and skip non-competitive documents.
+   */
+  public void setSkipNonCompetitiveDocs() {

Review comment:
       I wonder if we should make the option less ambiguous by naming it 
something like `setCanUsePoints` or something along those lines ? I am afraid 
that this could be misleading if we set this option on a sort field that use 
the _score or a keyword field for instance. We should maybe at least validate 
that the field is not `null` ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to