jimczi commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445476294
##########
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##########
@@ -439,12 +441,19 @@
/**
* Syntax flag, enables all optional regexp syntax.
*/
- public static final int ALL = 0xffff;
-
+ public static final int ALL = 0xff;
+
/**
* Syntax flag, enables no optional regexp syntax.
*/
public static final int NONE = 0x0000;
+
+ //----- Matching flags ( > 0xff ) ------
+
+ /**
+ * Allows case insensitive matching of ASCII characters.
+ */
+ public static final int ASCII_CASE_INSENSITIVE = 0x0100;
Review comment:
Let's call it CASE_INSENSITIVE since we want to leave the door for
another flag that would control if unicode should be handled fully ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
