s1monw opened a new pull request #1617: URL: https://github.com/apache/lucene-solr/pull/1617
This PR revisits the merge-on-commit patch submitted by @msfroh a little while ago. The only change from that earlier PR is a fix for failures uncovered by TestIndexWriter.testRandomOperations, some whitespace cleanups, and a rebase on the current master branch. The problem was that updateSegmentInfosOnMergeFinish would incorrectly decRef a merged segments' files if that segment was modified by deletions (or updates) while it was being merged. With this fix, I ran the failing test case several thousands of times with no failures, whereas before it would routinely fail after a few hundred test runs. Co-authored-by: Michael Froh <msf...@apache.org> Co-authored-by: Michael Sokolov <soko...@falutin.net> This is the third try after the patch itself and #1552 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
