atris commented on a change in pull request #1626: URL: https://github.com/apache/lucene-solr/pull/1626#discussion_r448496902
########## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.util.circuitbreaker; + +import java.lang.invoke.MethodHandles; +import java.lang.management.ManagementFactory; +import java.lang.management.MemoryMXBean; + +import org.apache.solr.core.SolrConfig; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * <p> + * Tracks the current JVM heap usage and triggers if it exceeds the defined percentage of the maximum + * heap size allocated to the JVM. This circuit breaker is a part of the default CircuitBreakerManager + * so is checked for every request -- hence it is realtime. Once the memory usage goes below the threshold, + * it will start allowing queries again. + * </p> + * + * <p> + * The memory threshold is defined as a percentage of the maximum memory allocated -- see memoryCircuitBreakerThresholdPct + * in solrconfig.xml. + * </p> + */ + +public class MemoryCircuitBreaker extends CircuitBreaker { + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + private static final MemoryMXBean MEMORY_MX_BEAN = ManagementFactory.getMemoryMXBean(); + + private final long heapMemoryThreshold; + + // Assumption -- the value of these parameters will be set correctly before invoking getDebugInfo() + private final ThreadLocal<Long> seenMemory = new ThreadLocal<>(); + private final ThreadLocal<Long> allowedMemory = new ThreadLocal<>(); + + public MemoryCircuitBreaker(SolrConfig solrConfig) { + super(solrConfig); + + long currentMaxHeap = MEMORY_MX_BEAN.getHeapMemoryUsage().getMax(); + + if (currentMaxHeap <= 0) { + throw new IllegalArgumentException("Invalid JVM state for the max heap usage"); + } + + int thresholdValueInPercentage = solrConfig.memoryCircuitBreakerThresholdPct; + double thresholdInFraction = thresholdValueInPercentage / (double) 100; + heapMemoryThreshold = (long) (currentMaxHeap * thresholdInFraction); + + if (heapMemoryThreshold <= 0) { + throw new IllegalStateException("Memory limit cannot be less than or equal to zero"); + } + } + + // TODO: An optimization can be to trip the circuit breaker for a duration of time + // after the circuit breaker condition is matched. This will optimize for per call + // overhead of calculating the condition parameters but can result in false positives. + @Override + public boolean isTripped() { + if (!isEnabled()) { + return false; + } + + allowedMemory.set(getCurrentMemoryThreshold()); + + seenMemory.set(calculateLiveMemoryUsage()); + + return (seenMemory.get() >= allowedMemory.get()); Review comment: It would be a two step process -- setting local value and then setting the thread local. Seems cleaner this way? I doubt if it will really cause a performance issue -- the variables are thread local ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
