[ https://issues.apache.org/jira/browse/SOLR-14540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152174#comment-17152174 ]
Cassandra Targett commented on SOLR-14540: ------------------------------------------ [~mkhl], Sorry, I completely missed this when you pinged me about it a month ago. I think it makes sense to just add a new section to {{json-query-dsl.adoc}}, since there isn't a section that feels right. You could improve your example to make it fit its own section by adding a little bit of context and/or linking to where the concepts are explained, and changing the inline comments to use callouts (shown in the example you pointed to in your question above) to explain what's happening a little more. > Ref Guide: Document how-to for Block Join Facets via Query DSL > -------------------------------------------------------------- > > Key: SOLR-14540 > URL: https://issues.apache.org/jira/browse/SOLR-14540 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Mikhail Khludnev > Priority: Major > > Solr has an old good feature > https://lucene.apache.org/solr/guide/8_5/faceting.html#tagging-and-excluding-filters. > I'd like to document similar solution/snippet for > https://lucene.apache.org/solr/guide/8_5/json-faceting-domain-changes.html#block-join-domain-changes > in Query DSL. This solution combines several elements, so it's not clear > where to put it. Does it deserve separate page or just a paragraph somewhere? > Snippet is already > [there|https://issues.apache.org/jira/browse/SOLR-14419?focusedCommentId=17112869&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17112869] > it just needs some tweaks. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org