[ 
https://issues.apache.org/jira/browse/SOLR-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154037#comment-17154037
 ] 

Uwe Schindler commented on SOLR-14469:
--------------------------------------

The negatives are currently no-ops, because we only explicitely enable warnings.

I don't think (as David Smiley also mentioned), that {{Xlint:deprecation}} 
(enable!!!) should be added, because this makes usage of Solr's own 
deprecations impossible. This is by the way one reason why we have 
forbiddenapis and its "jdk-deprecated" signatures file. It differs from this 
warning in a way that only calls to Java are forbidden, but you still can call 
all other code marked as deprecated, including your own.

So in short: Use forbiddenapis to explicitely disable deprecated stuff (like 
done with jdk's deprecations). On the Solr/Lucene API side, we should have 
clear rules how the message looks like. But this more something for the 
source-patterns checker.

> Removed deprecated code in solr/core (master only)
> --------------------------------------------------
>
>                 Key: SOLR-14469
>                 URL: https://issues.apache.org/jira/browse/SOLR-14469
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>
> I'm currently working on getting all the warnings out of the code, so this is 
> something of a placeholder for a week or two.
> There will be sub-tasks, please create them when you start working on a 
> project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to