[ 
https://issues.apache.org/jira/browse/SOLR-11208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155640#comment-17155640
 ] 

Ilan Ginzburg commented on SOLR-11208:
--------------------------------------

I've put out a PR [https://github.com/apache/lucene-solr/pull/1664].

Tests pass. Would like somebody to take a look in case I missed something.

> Usage SynchronousQueue in Executors prevent large scale operations
> ------------------------------------------------------------------
>
>                 Key: SOLR-11208
>                 URL: https://issues.apache.org/jira/browse/SOLR-11208
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 6.6
>            Reporter: Björn Häuser
>            Priority: Major
>         Attachments: response.json
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I am not sure where to start with this one.
> I tried to post this already on the mailing list: 
> https://mail-archives.apache.org/mod_mbox/lucene-solr-user/201708.mbox/%[email protected]%3e
> In short: the usage of a SynchronousQueue as the workQeue prevents more tasks 
> than max threads.
> For example, taken from OverseerCollectionMessageHandler:
> {code:java}
>   ExecutorService tpe = new ExecutorUtil.MDCAwareThreadPoolExecutor(5, 10, 
> 0L, TimeUnit.MILLISECONDS,
>       new SynchronousQueue<>(),
>       new 
> DefaultSolrThreadFactory("OverseerCollectionMessageHandlerThreadFactory"));
> {code}
> This Executor is used when doing a REPLACENODE (= ADDREPLICA) command. When 
> the node has more than 10 collections this will fail with the mentioned 
> java.util.concurrent.RejectedExecutionException.
> I am also not sure how to fix this. Just replacing the queue with a different 
> implementation feels wrong to me or could cause unwanted side behaviour.
> Thanks



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to