noblepaul commented on a change in pull request #1669:
URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454854570
##########
File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java
##########
@@ -188,6 +190,7 @@ public IndexSchema(String name, InputSource is, Version
luceneVersion, SolrResou
protected IndexSchema(Version luceneVersion, SolrResourceLoader loader,
Properties substitutableProperties) {
this.luceneVersion = Objects.requireNonNull(luceneVersion);
this.loader = loader;
+ this.solrClassLoader = loader.getCore() == null? loader:
loader.getCore().getSchemaPluginsLoader();
Review comment:
At this point I want this to get out of my way. I would fix this one
instead of spending more time on SRL refactoring.
I believe this is in a reasonably good shape. We can do more refactoring
later.
Let's do things that add value to users
TBH, I don't care about any particular class here. If possible, I would just
nuke SRL altogether. It's just a kitchen sink and reeks of bad designs all over
I wish to use SRL minimally. We should have a less heavy interface in most
places. I would say most places are happy to just have a `SolrClassLoader`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
