[
https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159112#comment-17159112
]
Uwe Schindler edited comment on SOLR-13939 at 7/16/20, 10:54 AM:
-----------------------------------------------------------------
Hi,
Windows is happy again. So your fix helped. I responded to mailing list, here
again:
{quote}
In Zookeeper alls paths are forward slashes (as it is a "path" inside the
zookeeper environment). If you replace that with a NIO Windows Path it creates
backslashes. This makes Zookeeper fail (of course).
Actually using the Hadoop class is broken workaround, it may be better to use
the more abstract java.net.URI class for correct "path" transformations. The
risk with java.nio.file.Path is also that if the path exists in file system it
handles the resolving different. So if some user has for some reason a local
path exactly looking like a zookeper node path it would use different behaviour.
So my suggestion: Use java.net.URI to build the path and use URI.getPath() or
similar to make a String out of it. The alternative to replace all backslashes
in the path to forwards slashes is a bad idea for the reasons I explained
before.
{quote}
Now we should replace the hadoop class IMHO by java.net.URI.
was (Author: thetaphi):
Hi,
Windows is happy again. I responded to mailing list, here again:
{quote}
In Zookeeper alls paths are forward slashes (as it is a "path" inside the
zookeeper environment). If you replace that with a NIO Windows Path it creates
backslashes. This makes Zookeeper fail (of course).
Actually using the Hadoop class is broken workaround, it may be better to use
the more abstract java.net.URI class for correct "path" transformations. The
risk with java.nio.file.Path is also that if the path exists in file system it
handles the resolving different. So if some user has for some reason a local
path exactly looking like a zookeper node path it would use different behaviour.
So my suggestion: Use java.net.URI to build the path and use URI.getPath() or
similar to make a String out of it. The alternative to replace all backslashes
in the path to forwards slashes is a bad idea for the reasons I explained
before.
{quote}
BTW, Windows is happy again! So you fix helped. Now we should replace the
hadoop class IMHO by java.net.URI.
> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from
> gradle effort
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-13939
> URL: https://issues.apache.org/jira/browse/SOLR-13939
> Project: Solr
> Issue Type: Sub-task
> Reporter: Dawid Weiss
> Assignee: Erick Erickson
> Priority: Major
> Fix For: 8.7
>
> Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
