murblanc commented on a change in pull request #1679:
URL: https://github.com/apache/lucene-solr/pull/1679#discussion_r456447471
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
##########
@@ -446,7 +444,6 @@ public static Modify modifyCollection(String collection,
Map<String, Object> pro
protected Boolean autoAddReplicas;
protected String alias;
protected String[] rule , snitch;
- protected String withCollection;
Review comment:
Do we remove the notion of `withCollection` with the Autoscaling
framework?
I would prefer to let the client manage it manually (i.e. specify its
replica placement carefully) if there's a co-location need, but if we keep it
we need to keep it here as well I believe, and if we remove it there are many
other places from which it should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
