bruno-roustant commented on a change in pull request #1675:
URL: https://github.com/apache/lucene-solr/pull/1675#discussion_r456530567
##########
File path: solr/core/src/java/org/apache/solr/metrics/SolrCoreMetricManager.java
##########
@@ -92,10 +92,10 @@ public void loadReporters() {
* are carried over and will be used under the new core name.
* This method also reloads reporters so that they use the new core name.
*/
- public void afterCoreSetName() {
+ public void afterCoreRename() {
+ assert core.getCoreDescriptor().getCloudDescriptor() == null;
Review comment:
Should it call apiAssumeStandalone()?
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -487,10 +488,13 @@ public String getName() {
}
public void setName(String v) {
+ Objects.requireNonNull(v);
+ boolean renamed = this.name != null && !this.name.equals(v);
+ assert !renamed || coreDescriptor.getCloudDescriptor() == null : "Cores
are not renamed in SolrCloud";
Review comment:
Should it call apiAssumeStandalone()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
