[ 
https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160631#comment-17160631
 ] 

Munendra S N commented on SOLR-14583:
-------------------------------------

 [^SOLR-14583.patch] 
[~jdyer] 
I was testing out other parameters with {{maxResultsForSuggest=0}}, I think it 
doesn't work as expected with {{alternativeTermCount}}. I think we should 
expose the suggestMode directly, instead of current options. It would be much 
clearer. For this jira, I'm planning to commit current patch so that 
{{maxResultsForSuggest=0}} supported as it was done previously and raise 
different issues for deprecating {{onlyMorePopular}} and exposing suggestMode 
as different parameter

> Spell suggestion is returned even if hits are non-zero when 
> spellcheck.maxResultsForSuggest=0
> ---------------------------------------------------------------------------------------------
>
>                 Key: SOLR-14583
>                 URL: https://issues.apache.org/jira/browse/SOLR-14583
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Munendra S N
>            Assignee: Munendra S N
>            Priority: Major
>         Attachments: SOLR-14583.patch, SOLR-14583.patch
>
>
> SOLR-4280 added to support fractional support for 
> spellcheck.maxResultsForSuggest. After SOLR-4280, 
> {{spellcheck.maxResultsForSuggest=0}} is treated same as not specify the 
> {{spellcheck.maxResultsForSuggest}} parameter. This can cause spell 
> suggestions to be returned even when hits are non-zero and greater than 
> {{spellcheck.maxResultsForSuggest}} (i.e, greater than 0)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to