noblepaul commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r457777268
########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/Replica.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * An instantiation (or one of the copies) of a given {@link Shard} of a given {@link SolrCollection}. + * Objects of this type are returned by the Solr framework to the plugin, they are not built by the plugin. When the + * plugin wants to add a replica it goes through {@link WorkOrderFactory#createWorkOrderCreateReplica}). + * TODO is there an elegant way to have this type also used by the plugin to add replicas? (insisting on elegant) + */ +public interface Replica { Review comment: Do we need to add a class for this? Isn't it good enough to use the existing class? ########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/PropertyKeyFactory.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * Factory used by the plugin to create property keys to request property values from Solr + */ +public interface PropertyKeyFactory { Review comment: PrpertyKey can be an enum? ########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/CreateCollectionRequest.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * <p>Request for creating a new collection with a given number of shards and replication factor for various replica types.</p> + * + * Note there is no need at this stage to allow the request to convey each shard hash range for example, this can be handled + * by the Solr side implementation without needing the plugin to worry about it. + * + */ +public interface CreateCollectionRequest extends Request { + String getCollectionName(); + + int getShardCount(); + + int getNRTReplicationFactor(); Review comment: `getNrtReplicaCount()` ? and so on ? ########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/ReplicaType.java ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * TODO: move into {@link Replica}? + */ +public enum ReplicaType { Review comment: Why not reuse the existing Replica.Type enum ? ########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/SolrCollection.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +import java.util.Set; + +/** + * Represents a Collection in SolrCloud. Although naming this class "Collection" is possible it would be confusing. + */ +public interface SolrCollection { Review comment: Why don't we use the standard DocCollection class ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
