rishisankar opened a new pull request #1688: URL: https://github.com/apache/lucene-solr/pull/1688
<!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr: * https://issues.apache.org/jira/projects/LUCENE * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> * SOLR-####: <short description of problem or changes> LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description As of now, the [Http2SolrClient](https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java) and the [LBHttp2SolrClient](https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java) both have support for making async requests, but there isn't a way to use these methods from a [CloudHttp2SolrClient](https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java). My change introduces an async request method to the CloudHttp2SolrClient which internally calls the LBHttp2SolrClient's async request method, and returns a Cancellable. # Solution I created a new method `CloudHttp2SolrClient#asyncRequest(SolrRequest request, String collection, AsyncListener<LBSolrClient.Rsp> asyncListener)` which makes an async request. In BaseCloudSolrClient, I modified `requestWithRetryOnStaleState` and `sendRequest` to take in an AsyncListener parameter, and they check if the listener is null or not to determine whether or not to make an async request. To return a Cancellable in the asyncRequest without changing the return type of the BaseCloudSolrClient request methods, the `BaseCloudSolrClient#makeRequest` method returns a NamedList containing the Cancellable object to be returned by the CloudHttp2SolrClient's asyncRequest method. # Tests I have added a test to [CloudHttp2SolrClientTest.java](https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java) that confirms that successful async requests result in an `onSuccess()` callback method being run. This test only serves to confirm that async requests properly branch to the `LBHttp2SolrClient.asyncReq()` method; it doesn't check the correctness of the response (i.e. it assumes that `LBHttp2SolrClient.asyncReq()` works correctly). # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
