[ 
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170465#comment-17170465
 ] 

Ishan Chattopadhyaya edited comment on SOLR-14702 at 8/4/20, 1:17 AM:
----------------------------------------------------------------------

{code}
Master and Slave

A Solr replication master is a single node which receives all updates initially 
and keeps everything organized. Solr replication slave nodes receive no updates 
directly, instead all changes (such as inserts, updates, deletes, etc.) are 
made against the single master node. Changes made on the master are distributed 
to all the slave nodes which service all query requests from the clients.
{code}
^ Quoting from https://lucene.apache.org/solr/guide/6_6/index-replication.html

I think this is the crux of my confusion. "master is a single node" makes it 
seem that master is a node level concept. In that case, it is incompatible with 
SolrCloud terminology. On the other hand, if "master/slave" is a 
core/collection level concept in standalone Solr (I see solrconfig.xml changes 
are needed, so this may be the case?), then I have -no- less problems renaming 
it to "leader/follower". In such a case, we shouldn't then call it "leader 
node", but a leader core. I don't know standalone Solr enough to know to clear 
my own confusion. I fully stand by primary/secondary to distinguish from 
SolrCloud terminology.


was (Author: ichattopadhyaya):
{code}
Master and Slave

A Solr replication master is a single node which receives all updates initially 
and keeps everything organized. Solr replication slave nodes receive no updates 
directly, instead all changes (such as inserts, updates, deletes, etc.) are 
made against the single master node. Changes made on the master are distributed 
to all the slave nodes which service all query requests from the clients.
{code}
^ Quoting from https://lucene.apache.org/solr/guide/6_6/index-replication.html

I think this is the crux of my confusion. "master is a single node" makes it 
seem that master is a node level concept. In that case, it is incompatible with 
SolrCloud terminology. On the other hand, if "master/slave" is a 
core/collection level concept in standalone Solr (I see solrconfig.xml changes 
are needed, so this may be the case?), then I have no problems renaming it to 
"leader/follower". In such a case, we shouldn't then call it "leader node", but 
a leader core. I don't know standalone Solr enough to know to clear my own 
confusion.

> Remove Master and Slave from Code Base and Docs
> -----------------------------------------------
>
>                 Key: SOLR-14702
>                 URL: https://issues.apache.org/jira/browse/SOLR-14702
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (9.0)
>            Reporter: Marcus Eagan
>            Priority: Critical
>         Attachments: SOLR-14742-testfix.patch
>
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> Every time I read _master_ and _slave_, I get pissed.
> I think about the last and only time I remember visiting my maternal great 
> grandpa in Alabama at four years old. He was a sharecropper before WWI, where 
> he lost his legs, and then he was back to being a sharecropper somehow after 
> the war. Crazy, I know. I don't know if the world still called his job 
> sharecropping in 1993, but he was basically a slave—in America. He lived in 
> the same shack that his father, and his grandfather (born a slave) lived in 
> down in Alabama. Believe it or not, my dad's (born in 1926) grandfather was 
> actually born a slave, freed shortly after birth by his owner father. I never 
> met him, though. He died in the 40s.
> Anyway, I cannot police all terms in the repo and do not wish to. This 
> master/slave shit is archaic and misleading on technical grounds. Thankfully, 
> there's only a handful of files in code and documentation that still talk 
> about masters and slaves. We should replace all of them.
> There are so many ways to reword it. In fact, unless anyone else objects or 
> wants to do the grunt work to help my stress levels, I will open the pull 
> request myself in effort to make this project and community more inviting to 
> people of all backgrounds and histories. We can have leader/follower, or 
> primary/secondary, but none of this Master/Slave nonsense. I'm sick of the 
> garbage. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to