MarcusSorealheis commented on pull request #1712: URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668407860
I suppose I should convert this back to draft. I don't think it all the comments makes sense, but there is one place I think it does make sense to preserve the name: `ReplicationHandler`. I didn't see the mail that went out from Anshum originally where there was some discussion. I started on this effort because I was sick of seeing things in the code base. I need to do some more investigation. I don't want to rush this out given the complexity and all the moving parts. I need to figure out if it makes sense to refactor some of these classes to separate concerns. Probably not because I don't want to add any duplicated logic unless there's a better reason than names. I'll come back sometime tomorrow, probably at night. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
