dweiss commented on pull request #1721: URL: https://github.com/apache/lucene-solr/pull/1721#issuecomment-673296232
I will split the original issue into two - one adjusting Matches API slightly and the other with highlighter components on top of that API; I'll provide some more high-level description then. In short: it's a different angle to highlighting query hits. I think it's simpler internally (relies on matches API almost entirely - it has no knowledge of query types, etc, occasionally reverse-engineering offsets from positions). And from the outside it's really flexible because it gives you all the controls to build your own highlighting code (however you wish it to work). It doesn't have all the bells and whistles of UnifiedHighlighter but at the same time there's nothing preventing you from adding these (snippet scoring is very simple, for example). If you take a look at the test case you'll see that it works really nice, in spite of not knowing anything about underlying query types. The remaining classes (passage selector, overlap conflict resolution) are auxiliary classes I already had for my own needs (again - none of the existing code in Lucene fulfilled all my expectations) so I added them in, perhaps they'll be useful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
