yuriy-b-koval commented on pull request #1713: URL: https://github.com/apache/lucene-solr/pull/1713#issuecomment-673719711
> Hey @yuriy-b-koval , it took me awhile to understand it, but I spent some time brushing up on edismax and am confident enough to say this LGTM now. > > That said - one thing that might still be nice here would be to have unit tests on ExtendedDismaxQParser.splitIntoClauses itself. That'd give us more targeted validation of your change here. It'd also give us a regression barrier in case someone breaks the logic in splitIntoClauses somewhere down the road. > > Would you be willing to tackle those tests? (Or did you already try to write tests at that level and run into some roadblock or other?) They're not strictly necessary, but I'd like one of us to give them a shot if we can before merging. Adding some tests calling ExtendedDismaxQParser.splitIntoClauses directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
