[
https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177466#comment-17177466
]
David Smiley commented on SOLR-13998:
-------------------------------------
When filing an issue that creates two interfaces, please say their names in the
description. I noticed this issue originally but didn't look further at the
time to see what the actual annotation names were; I wish I had. I'm cool with
"SolrThreadSafe" as a name, but not "SolrSingleThreaded". Can we just call
that "SolrNotThreadSafe" please? "SingleThreaded" suggests it has some
algorithm inside that does not use threads or maybe creates and uses exactly
one... when really we are trying to say that the class is not safe for
concurrent use _calling into it_ (thus not "thread-safe") as it's javadocs say.
Some googling shows "NotThreadSafe" annotation shows up in other projects; we
can use the same understood name.
BTW What Mark miller created many months ago was not public; only his
colleagues including Anshum are privy to it.
> Add thread safety annotation to classes
> ---------------------------------------
>
> Key: SOLR-13998
> URL: https://issues.apache.org/jira/browse/SOLR-13998
> Project: Solr
> Issue Type: Improvement
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Major
> Fix For: master (9.0), 8.4
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add annotations that can be used to mark classes as thread safe / single
> threaded in Solr.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
