[
https://issues.apache.org/jira/browse/SOLR-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177734#comment-17177734
]
Jason Gerlowski commented on SOLR-14596:
----------------------------------------
For CollectionAdminRequest at least, I think you're right. I figured this out
most of the way through writing those methods, but decided to finish the way I
started so that I could consider it between patches. I'm going to add tests to
make sure that works the way we want it to, but granted that works out I'm
going to head the {{getParams}} direction in my next iteration of this.
(You can't _just_ call equals on getParams technically - there's other stuff
involved like the HTTP method, username/password, etc. But a lot of that can
be handled at the SolrRequest level and then subclasses can just call
super.equals() to run those checks.)
> Add equals()/hashCode() impls to SolrJ Request objects
> ------------------------------------------------------
>
> Key: SOLR-14596
> URL: https://issues.apache.org/jira/browse/SOLR-14596
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Affects Versions: master (9.0), 8.5.2
> Reporter: Jason Gerlowski
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, many SolrRequest classes (e.g. UpdateRequest) don't implement
> {{equals()}} or {{hashCode()}}
> This isn't a problem for Solr's normal operation, but it can be a barrier in
> unit testing SolrJ client code. {{equals()}} implementations would make it
> much easier to assert that client code is building the request that
> developers _think_ it's building. Of course, this testing benefit would
> apply to Solr's own tests which use SolrJ.
> This ticket covers making sure that the more popular SolrRequest objects have
> equals/hashcode implementations useful for testers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
