s1monw commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-674718362
> @s1monw I like your first commit :). I wonder if we can continue that approach by moving the merge logic outside fullFlushLock and reopen a new reader if the merge completes within the timeout? But, I might be missing something obvious here. hey @dnhatn I with we could! I first wrote a longish reply to your comment but then decided to push some documentation on how getReader works and why we can't do things outside of the lock, or at least not easily. Lemme know if it helps. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
