mikemccand commented on a change in pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r472154682



##########
File path: lucene/core/src/java/org/apache/lucene/index/ReaderPool.java
##########
@@ -404,7 +404,7 @@ private PendingDeletes newPendingDeletes(SegmentReader 
reader, SegmentCommitInfo
   private boolean noDups() {
     Set<String> seen = new HashSet<>();
     for(SegmentCommitInfo info : readerMap.keySet()) {
-      assert !seen.contains(info.info.name);
+      assert !seen.contains(info.info.name) : "seen twice: " + info.info.name ;

Review comment:
       I love seeing diffs like this one, adding a `String` message to an 
otherwise cryptic `assert`!  It makes me realize you must have had a hellacious 
debugging session!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to