[
https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182937#comment-17182937
]
David Smiley commented on SOLR-14651:
-------------------------------------
No; I think the documentation here is fine?
https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/metrics-history.adoc
(search for "enable")
> Metrics history could disable itself better
> -------------------------------------------
>
> Key: SOLR-14651
> URL: https://issues.apache.org/jira/browse/SOLR-14651
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 8.7
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The MetricsHistoryHandler should disable itself better than it does. It will
> create a SolrRrdBackendFactory (which has an ExecutorService / thread pool)
> when it should not when the plugin is disabled. Furthermore, I think this
> should be disabled by default in tests, as it's excessive machinery that
> don't matter to 99.9% of tests. This will help our tests run more
> efficiently.
> While working on other issues, I also occasionally saw a thread leak failure
> with the RRD being the leaked threads. I see that in "close", we don't
> _wait_ for the executor to actually shut down but it should.
> CC [~ab]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
